fix: let composing site own shell and brand CSS#1667
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1667 +/- ##
================================================
Coverage ? 92.08%
================================================
Files ? 93
Lines ? 2046
Branches ? 588
================================================
Hits ? 1884
Misses ? 159
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
force-pushed
the
fix-branding
branch
2 times, most recently
from
86487a2 to
836512a
Compare
arbrandes
changed the title
arbrandes
force-pushed
the
fix-branding
branch
3 times, most recently
from
308d561 to
1317651
Compare
The shell stylesheet moved from a SCSS file to a JS manifest at @openedx/frontend-base/shell/style. Imports it directly from site.config.dev.tsx and drops the now-redundant site.scss. Also fixes two @media queries in _base_component.scss that used a single-dash custom-media name and were silently non-matching. Refs openedx/frontend-base#232 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 22, 2026
|
🎉 This PR is included in version 1.0.0-alpha.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stops the app from re-bundling the shell stylesheet so lazy-loaded app chunks no longer re-declare Paragon's
:rootcustom properties and clobber the composing site's brand tokens at runtime. The dev harness now pulls the shell styles in through@openedx/frontend-base/shell/style(a JS manifest exposed by frontend-base) directly fromsite.config.dev.tsx, while app-scoped styles continue to load per-chunk throughMain.tsxviasrc/style.scss. The./app.scsssubpath export and thesrc/app.scssentry are both removed since composing sites no longer need to pull in the app's rules at site-build time.Also fixes two
@mediaqueries in_base_component.scssthat used a single-dash custom-media name (-pgn-...) and were silently non-matching.The dev harness runs unbranded now, so
@edx/brandis dropped from the repo entirely rather than demoted to a devDependency.Refs openedx/frontend-base#232.
LLM usage notice
Built with assistance from Claude.